[FFmpeg-trac] #4842(avcodec:new): wrong mask in dxv

FFmpeg trac at avcodec.org
Thu Sep 10 13:05:38 CEST 2015


#4842: wrong mask in dxv
-------------------------------------+-------------------------------------
             Reporter:               |                     Type:  defect
  projectsymphony                    |                 Priority:  normal
               Status:  new          |                  Version:  git-
            Component:  avcodec      |  master
             Keywords:               |               Blocked By:
             Blocking:               |  Reproduced by developer:  0
Analyzed by developer:  0            |
-------------------------------------+-------------------------------------
 for some reason 9b2802f0d3296059a61b0f323ee0fc86eba48bf5 was applied
 without any explanation

 besides the fact that the decoder has been tested across several "real-
 world" files, the test is clearly wrong and could lead to awful results.

 {{{
 if (old_type & 0x20 || old_type & 0x2)
 }}}
 should definitely be
 {{{
 if ((old_type & 0x20) || (old_type & 0x2))
 }}}

 would it be possible to have one of the samples that made this change
 necessary?

--
Ticket URL: <https://trac.ffmpeg.org/ticket/4842>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker


More information about the FFmpeg-trac mailing list