[FFmpeg-trac] #5976(avformat:open): flv encoding for live stream no longer usable
FFmpeg
trac at avcodec.org
Thu Nov 24 15:43:04 EET 2016
#5976: flv encoding for live stream no longer usable
------------------------------------+-------------------------------------
Reporter: jyavenard | Owner: stevenliu
Type: defect | Status: open
Priority: normal | Component: avformat
Version: git-master | Resolution:
Keywords: | Blocked By:
Blocking: | Reproduced by developer: 0
Analyzed by developer: 0 |
------------------------------------+-------------------------------------
Comment (by stevenliu):
Replying to [comment:6 jyavenard]:
> Thank you for the quick fix.
>
> So by default, the old behavior is back.
>
> {{{
> @@ -844,7 +846,7 @@ end:
> avio_seek(pb, flv->datasize_offset, SEEK_SET);
> put_amf_double(pb, flv->datasize);
> }
> - if (pb->seekable) {
> + if (!(flv->flags & FLV_NO_DURATION_FILESIZE)) {
> /* update information */
> }}}
>
> why not use if (write_duration_filesize) ?
Because this is in flv_write_trailer and only be used once, so don't need
use other variable to make it simple.
--
Ticket URL: <https://trac.ffmpeg.org/ticket/5976#comment:7>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker
More information about the FFmpeg-trac
mailing list