[FFmpeg-trac] #6362(ffmpeg:new): expression is always false

FFmpeg trac at avcodec.org
Tue May 2 09:32:46 EEST 2017


#6362: expression is always false
-------------------------------------+-------------------------------------
             Reporter:  Appchecker   |                     Type:  defect
               Status:  new          |                 Priority:  normal
            Component:  ffmpeg       |                  Version:  2.8.11
             Keywords:  weakness,    |               Blocked By:
  expression false, cwe-570, code    |  Reproduced by developer:  0
  defect                             |
             Blocking:               |
Analyzed by developer:  0            |
-------------------------------------+-------------------------------------
 Hello!

 We've checked your code with appChecker static analyzer
 (https://cnpo.ru/en/solutions/appchecker.php) and found possible bug:

 https://github.com/FFmpeg/FFmpeg/blob/59d219b91ef6c8f5415e174c920e07629312d1d6/libavformat/nutdec.c#L205

 {{{
    if (nut->version < NUT_MIN_VERSION &&
         nut->version > NUT_MAX_VERSION) {
         av_log(s, AV_LOG_ERROR, "Version %d not supported.\n",
                nut->version);
         return AVERROR(ENOSYS);
     }
 }}}

 nut->version can't be < NUT_MIN_VERSION (2) and > NUT_MAX_VERSION (4) at
 the same time.

 Possible defects were found by Echelon Team with appChecker static
 analyzer(https://cnpo.ru/en/solutions/appchecker.php)

--
Ticket URL: <https://trac.ffmpeg.org/ticket/6362>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker


More information about the FFmpeg-trac mailing list