[FFmpeg-trac] #6741(undetermined:new): ffmpeg-3.4/libavfilter/vf_cover_rect.c:155: suspicious if ?
FFmpeg
trac at avcodec.org
Tue Oct 17 12:10:10 EEST 2017
#6741: ffmpeg-3.4/libavfilter/vf_cover_rect.c:155: suspicious if ?
-------------------------------------+-------------------------------------
Reporter: dcb | Type: defect
Status: new | Priority: normal
Component: | Version:
undetermined | unspecified
Keywords: | Blocked By:
Blocking: | Reproduced by developer: 0
Analyzed by developer: 0 |
-------------------------------------+-------------------------------------
ffmpeg-3.4/libavfilter/vf_cover_rect.c:155] ->
[ffmpeg-3.4/libavfilter/vf_cover_rect.c:155]: (style) Same expression on
both sides of '||'.
Source code is
if (!xendptr || *xendptr || !yendptr || *yendptr ||
!wendptr || *wendptr || !hendptr || !hendptr
maybe better code
if (!xendptr || *xendptr || !yendptr || *yendptr ||
!wendptr || *wendptr || !hendptr || !*hendptr
--
Ticket URL: <https://trac.ffmpeg.org/ticket/6741>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker
More information about the FFmpeg-trac
mailing list