[FFmpeg-trac] #6749(avcodec:new): ffmpeg-3.4/libavcodec/eatqi.c:115: suspicious assignment ?

FFmpeg trac at avcodec.org
Tue Oct 17 12:34:43 EEST 2017


#6749: ffmpeg-3.4/libavcodec/eatqi.c:115: suspicious assignment ?
---------------------------------+---------------------------------------
             Reporter:  dcb      |                     Type:  defect
               Status:  new      |                 Priority:  normal
            Component:  avcodec  |                  Version:  unspecified
             Keywords:           |               Blocked By:
             Blocking:           |  Reproduced by developer:  0
Analyzed by developer:  0        |
---------------------------------+---------------------------------------
 ffmpeg-3.4/libavcodec/eatqi.c:115]: (style) int result is assigned to long
 variable.

 Source code is

     const int64_t qscale = (215 - 2*quant)*5;

 maybe better code

     const int64_t qscale = (215L - 2*quant)*5;

--
Ticket URL: <https://trac.ffmpeg.org/ticket/6749>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker


More information about the FFmpeg-trac mailing list