[FFmpeg-trac] #7372(avcodec:new): [regression][eac3] Unable to parse channels information while compiling with ac3 decoder disabled.

FFmpeg trac at avcodec.org
Wed Aug 22 13:51:12 EEST 2018


#7372: [regression][eac3] Unable to parse channels information while compiling
with ac3 decoder disabled.
------------------------------------+-----------------------------------
             Reporter:  apasyniuk   |                    Owner:
                 Type:  defect      |                   Status:  new
             Priority:  normal      |                Component:  avcodec
              Version:  git-master  |               Resolution:
             Keywords:              |               Blocked By:
             Blocking:              |  Reproduced by developer:  0
Analyzed by developer:  0           |
------------------------------------+-----------------------------------

Comment (by apasyniuk):

 I try this and yes it works now.
 Maybe it's good idea to add this config check to next if with bit_rate
 parameter?
 {{{
 diff --git a/third_party/ffmpeg/libavcodec/aac_ac3_parser.c
 b/third_party/ffmpeg/libavcodec/aac_ac3_parser.c
 index 54e459844f14..46e73014560e 100644
 --- a/third_party/ffmpeg/libavcodec/aac_ac3_parser.c
 +++ b/third_party/ffmpeg/libavcodec/aac_ac3_parser.c
 @@ -89,7 +89,7 @@ get_next:
             the frame). */
          if (avctx->codec_id != AV_CODEC_ID_AAC) {
              avctx->sample_rate = s->sample_rate;
 -            if (avctx->codec_id != AV_CODEC_ID_EAC3) {
 +            if ((CONFIG_EAC3_DECODER && avctx->codec_id !=
 AV_CODEC_ID_EAC3) || (!CONFIG_EAC3_DECODER)) {
                  avctx->channels = s->channels;
                  avctx->channel_layout = s->channel_layout;
              }
 @@ -97,7 +97,7 @@ get_next:
              avctx->audio_service_type = s->service_type;
          }

 -        if (avctx->codec_id != AV_CODEC_ID_EAC3)
 +        if ((CONFIG_EAC3_DECODER && avctx->codec_id != AV_CODEC_ID_EAC3)
 || (!CONFIG_EAC3_DECODER))
              avctx->bit_rate = s->bit_rate;
      }
 }}}

--
Ticket URL: <https://trac.ffmpeg.org/ticket/7372#comment:2>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker


More information about the FFmpeg-trac mailing list