[FFmpeg-trac] #6216(avcodec:open): TrueHD encoder creates non bitexact files

[FFmpeg]

#6216: TrueHD encoder creates non bitexact files
------------------------------------+-----------------------------------
             Reporter:  James       |                    Owner:  (none)
                 Type:  defect      |                   Status:  open
             Priority:  normal      |                Component:  avcodec
              Version:  git-master  |               Resolution:
             Keywords:  thd         |               Blocked By:
             Blocking:              |  Reproduced by developer:  0
Analyzed by developer:  0           |
------------------------------------+-----------------------------------
Changes (by Balling):

 * status:  new => open

Comment:

 I suppose this patch.
 https://patchwork.ffmpeg.org/project/ffmpeg/patch/20171128195544.5283-1-onemda@gmail.com/
 by Paul. I can confirm that last frame is indeed not encoded on my not
 seekable sample too.

 As for bitness, that is strange bug, as bitness makes little sense for
 TrueHD, not only that but 24 from 32 bit encoder is not even activated
 yet! It was supposed to be activated here https://ffmpeg.org/pipermail
 /ffmpeg-devel/2019-July/246357.html (patch not on patchwork, of course, no
 surprises here) but was NAK'ed by Lynne here:
 https://patchwork.ffmpeg.org/project/ffmpeg/patch/20190710035638.30961-1-me@jailuthra.in/#41950


 Second patch in series
 https://patchwork.ffmpeg.org/project/ffmpeg/patch/20171128195544.5283-2-onemda@gmail.com/
 evolved into c1c3916cec9ca627b9bff4a34683f66664ff787d because of logic by
 author here:
 https://patchwork.ffmpeg.org/project/ffmpeg/patch/20190709201901.26693-1-me@jailuthra.in/#41930

 32 bit activation happens by just adding AV_SAMPLE_FMT_S32 in two places,
 not cool it is not on.
-- 
Ticket URL: <https://trac.ffmpeg.org/ticket/6216#comment:3>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker