[FFmpeg-trac] #10699(avfilter:new): heap-buffer-overflow at libavfilter/edge_template.c:116:5 in ff_gaussian_blur_8 in FFmpeg

[FFmpeg]

#10699: heap-buffer-overflow at libavfilter/edge_template.c:116:5 in
ff_gaussian_blur_8 in FFmpeg
--------------------------------------+------------------------------------
             Reporter:  ZengYunxiang  |                    Owner:  (none)
                 Type:  defect        |                   Status:  new
             Priority:  important     |                Component:  avfilter
              Version:  git-master    |               Resolution:
             Keywords:  bugs          |               Blocked By:
             Blocking:                |  Reproduced by developer:  0
Analyzed by developer:  0             |
--------------------------------------+------------------------------------
Comment (by ZengYunxiang):

 Hello. I also found this bug when using the edgedetect filter for fuzzing.
 Command: ./ffmpeg_g -y -i poc19ffmpeg -filter_complex edgedetect tmp.mp4
 The ASAN log is as follows:
 {{{
 =================================================================
 ==4079588==ERROR: AddressSanitizer: heap-buffer-overflow on address
 0x609000012a60 at pc 0x55fba344fefa bp 0x7f79beb26f90 sp 0x7f79beb26760
 WRITE of size 16 at 0x609000012a60 thread T19 (fc0)
     #0 0x55fba344fef9 in __asan_memcpy (/ffmpeg/ffmpeg_g+0x922ef9)
 (BuildId: 8d6ccf457a75d047d11f9627d0b67208c2215c8c)
     #1 0x55fba3df4ecb in ff_gaussian_blur_8
 /ffmpeg/libavfilter/edge_template.c:115:5
     #2 0x55fba37f4b91 in filter_frame
 /ffmpeg/libavfilter/vf_edgedetect.c:194:9
     #3 0x55fba35abed2 in ff_filter_frame_framed
 /ffmpeg/libavfilter/avfilter.c:969:11
     #4 0x55fba35abed2 in ff_filter_frame_to_filter
 /ffmpeg/libavfilter/avfilter.c:1123:11
     #5 0x55fba35abed2 in ff_filter_activate_default
 /ffmpeg/libavfilter/avfilter.c:1182:20
     #6 0x55fba35abed2 in ff_filter_activate
 /ffmpeg/libavfilter/avfilter.c:1341:11
     #7 0x55fba35bdf57 in push_frame /ffmpeg/libavfilter/buffersrc.c:168:15
     #8 0x55fba35bdf57 in av_buffersrc_add_frame_flags
 /ffmpeg/libavfilter/buffersrc.c:272:15
     #9 0x55fba34abd3b in send_frame
 /ffmpeg/fftools/ffmpeg_filter.c:2668:11
     #10 0x55fba34abd3b in filter_thread
 /ffmpeg/fftools/ffmpeg_filter.c:2808:19
     #11 0x55fba34edc18 in task_wrapper
 /ffmpeg/fftools/ffmpeg_sched.c:2200:21
     #12 0x7f79cac06ac2  (/lib/x86_64-linux-gnu/libc.so.6+0x94ac2)
 (BuildId: a43bfc8428df6623cd498c9c0caeb91aec9be4f9)
     #13 0x7f79cac98a3f  (/lib/x86_64-linux-gnu/libc.so.6+0x126a3f)
 (BuildId: a43bfc8428df6623cd498c9c0caeb91aec9be4f9)

 0x609000012a60 is located 0 bytes to the right of 32-byte region
 [0x609000012a40,0x609000012a60)
 allocated by thread T19 (fc0) here:
     #0 0x55fba3451697 in __interceptor_posix_memalign
 (/ffmpeg/ffmpeg_g+0x924697) (BuildId:
 8d6ccf457a75d047d11f9627d0b67208c2215c8c)
     #1 0x55fba6ab9abe in av_malloc /ffmpeg/libavutil/mem.c:105:9
     #2 0x55fba37f5a80 in config_props
 /ffmpeg/libavfilter/vf_edgedetect.c:134:29

 Thread T19 (fc0) created by T0 here:
     #0 0x55fba3439f9c in __interceptor_pthread_create
 (/ffmpeg/ffmpeg_g+0x90cf9c) (BuildId:
 8d6ccf457a75d047d11f9627d0b67208c2215c8c)
     #1 0x55fba34e8161 in task_start /ffmpeg/fftools/ffmpeg_sched.c:403:11
     #2 0x55fba3506e68 in transcode /ffmpeg/fftools/ffmpeg.c:922:11
     #3 0x55fba3506e68 in main /ffmpeg/fftools/ffmpeg.c:1050:11
     #4 0x7f79cab9bd8f  (/lib/x86_64-linux-gnu/libc.so.6+0x29d8f) (BuildId:
 a43bfc8428df6623cd498c9c0caeb91aec9be4f9)

 SUMMARY: AddressSanitizer: heap-buffer-overflow
 (/ffmpeg/ffmpeg_g+0x922ef9) (BuildId:
 8d6ccf457a75d047d11f9627d0b67208c2215c8c) in __asan_memcpy
 Shadow bytes around the buggy address:
   0x0c127fffa4f0: fd fd fd fa fa fa fa fa fa fa fa fa fa fa fa fa
   0x0c127fffa500: 00 00 fa fa fa fa fa fa fa fa fa fa fa fa fa fa
   0x0c127fffa510: 00 00 fa fa fa fa fa fa fa fa fa fa fa fa fa fa
   0x0c127fffa520: fa fa fa fa fa fa fa fa 00 00 00 fa fa fa fa fa
   0x0c127fffa530: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 fa fa
 =>0x0c127fffa540: fa fa fa fa fa fa fa fa 00 00 00 00[fa]fa fa fa
   0x0c127fffa550: fa fa fa fa fa fa fa fa 00 00 00 00 fa fa fa fa
   0x0c127fffa560: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
   0x0c127fffa570: 00 00 00 00 00 04 fa fa fa fa fa fa fa fa fa fa
   0x0c127fffa580: 00 00 04 fa fa fa fa fa fa fa fa fa fa fa fa fa
   0x0c127fffa590: fd fd fa fa fa fa fa fa fa fa fa fa fa fa fa fa
 Shadow byte legend (one shadow byte represents 8 application bytes):
   Addressable:           00
   Partially addressable: 01 02 03 04 05 06 07
   Heap left redzone:       fa
   Freed heap region:       fd
   Stack left redzone:      f1
   Stack mid redzone:       f2
   Stack right redzone:     f3
   Stack after return:      f5
   Stack use after scope:   f8
   Global redzone:          f9
   Global init order:       f6
   Poisoned by user:        f7
   Container overflow:      fc
   Array cookie:            ac
   Intra object redzone:    bb
   ASan internal:           fe
   Left alloca redzone:     ca
   Right alloca redzone:    cb
 ==4079588==ABORTING
 }}}
-- 
Ticket URL: <https://trac.ffmpeg.org/ticket/10699#comment:1>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker