Ticket #1050 (closed defect: fixed)

Opened 15 months ago

Last modified 15 months ago

Incomplete pkgconfig file libavdevice.pc

Reported by: marlam Owned by:
Priority: important Component: build system
Version: git-master Keywords: lavfi
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

Hi!

The information recorded in libavdevice.pc is sometimes incomplete.

When configured with indev lavfi (libavdevice/lavfi.c), which is the default, then libavdevice requires libavfilter, but that is not recorded in the Requires: or Requires.private: field.

Attachments

patchavdevicepc.diff Download (1.4 KB) - added by cehoyos 15 months ago.
patchavdevicepc2.diff Download (1.5 KB) - added by cehoyos 15 months ago.

Change History

comment:1 Changed 15 months ago by cehoyos

Could you send a patch to ffmpeg-devel?

comment:2 Changed 15 months ago by marlam

I tried to make a patch, but I was not able to figure out how the configure magic works.

How do I find out whether libavdevice/lavfi.c is enabled or not?

For libavfilter, there are 'enabled libavfilter_deps_*' tests, but I did not understand how these work.

Changed 15 months ago by cehoyos

comment:3 Changed 15 months ago by cehoyos

  • Priority changed from normal to important
  • Status changed from new to open

Could you test attached patch?

Changed 15 months ago by cehoyos

comment:4 Changed 15 months ago by cehoyos

Improved patch attached.

comment:5 Changed 15 months ago by marlam

It works beautifully here. Thank you very much!

The 'enabled lavfi_indev' test was the thing I could not figure out. Thanks for helping, I really appreciate it.

comment:6 Changed 15 months ago by cehoyos

  • Keywords lavfi added
  • Status changed from open to closed
  • Resolution set to fixed

Patch applied, thank you for testing!

Note: See TracTickets for help on using tickets.