Ticket #1463 (open enhancement)

Opened 11 months ago

Last modified 6 days ago

ffmpeg.exe on Windows does not respond properly to Ctrl+Break

Reported by: joewreschnig Owned by:
Priority: normal Component: FFmpeg
Version: git-master Keywords: win
Cc: rogerdpack Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

In addition to SIGINT, on Windows it is common to send a different signal, SIGBREAK, which has similar effects. This can be triggered by pressing Ctrl+Break or by another process sending a signal.

New process groups on WIn32 usually ignore SIGINT; it is customary to stop a process in a separate process group by sending SIGBREAK.

The attached patch makes ffmpeg.exe respond to SIGBREAK in the same way it does SIGINT, using the WIndows console "control event" handler.

Attachments

ffmpeg-sigbreak.diff Download (1.7 KB) - added by joewreschnig 11 months ago.
Patch against ~2012.06.18 git branch

Change History

Changed 11 months ago by joewreschnig

Patch against ~2012.06.18 git branch

comment:1 Changed 11 months ago by cehoyos

  • Keywords win added
  • Status changed from new to open
  • Version changed from unspecified to git-master

Please send patches to ffmpeg-devel, they receive more attention there.

comment:2 follow-up: ↓ 3 Changed 4 weeks ago by rogerdpack

appears this wasn't "quite" committed yet...as of today anyway...http://web.archiveorange.com/archive/v/4q4BhNEWTcX2aCpF2IWz

comment:3 in reply to: ↑ 2 Changed 4 weeks ago by cehoyos

  • Cc rogerdpack added

Replying to rogerdpack:

appears this wasn't "quite" committed yet...as of today anyway...http://web.archiveorange.com/archive/v/4q4BhNEWTcX2aCpF2IWz

If you want to push this patch, please resend a tested version to ffmpeg-devel. Posting a link (especially a non-working one) unfortunately does not help.

comment:4 Changed 6 days ago by rogerdpack

comment:5 Changed 6 days ago by cehoyos

If you are interested in this issue please consider reading my last comment.

Note: See TracTickets for help on using tickets.