ModPlug compile bug

[chinshou]

Summary of the bug:
when compile the ffmpeg with libmodplug --enable-libmodplug , gcc reported following error

operator new [] unresolved error

Fix: add stdc++ library to link parameters.

Patch attached.

[ubitux]

Can you check if pkg-config --libs libmodplug add -lstdc++ for you? And if so, use require_pkg_config instead for the check.

It might be better to use it; I don't need stdc++ here for example.

[chinshou]

executing pkg-config --libs libmodplug add -L/usr/darwin32/lib -lmodplug for the link parameters but without -lstdc++

it seems -lstdc++ defined in the Libs.private section not in the Libs section of the libmodplug.pc

prefix=/usr/darwin32
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include

Name: libmodplug
Description: The ModPlug? mod file playing library.
Version: 0.8.8.4
Requires:
Libs: -L${libdir} -lmodplug
Libs.private: -lstdc++ -lm
Cflags: -I${includedir} -I${includedir}/libmodplug

[ubitux]

What is your full ./configure line?

pkg-config --static --libs libmodplug should raise the appropriate libs. I don't know if the configure will be able to do that according to your options, but it might be worth giving a try.

I'm not familiar with the build system, but requiring this lib when it's not looks wrong to me.

[chinshou]

I attach a new patch which change to use require_pkg_config macro to create the link parameters. But it requires that add --static parameter to the check_pkg_config macro

I do not know whether it will cause some side effect by adding --static to check_pkg_config macro although the compile is ok now.

[ubitux]

AFAICT, the external libraries should not be linked statically (the default --enable-static switch enable static linking of libav* libraries), so libmodplug, as well as other external libraries will be linked dynamically.

Adding --static to the pkg-config call will add a lot of libraries dependencies where it is not required.

Are you trying to make a full static build? Again, what is your full configure line?

[chinshou]

no, I am creating a shared build but without external dependency , following is the full configure line.

LDFLAGS="-arch i386 -L/usr/darwin32/lib" CPPFLAGS="-arch i386 -I/usr/darwin32/include" CFLAGS="-arch i386 -I/usr/darwin32/include" ../configure --enable-memalign-hack --arch=x86 --target-os=darwin --prefix=/usr/darwin32 --enable-gpl --disable-postproc --enable-shared --enable-cross-compile --enable-libx264 --enable-libvpx --disable-decoder=libvpx --enable-libgsm --enable-libmp3lame --disable-encoder=aac --enable-libvo-amrwbenc --enable-libfreetype --enable-version3 --enable-libvo-aacenc --enable-libtheora --enable-libspeex --enable-libvorbis --enable-runtime-cpudetect --enable-libsox --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libxavs --enable-openal --enable-librtmp --enable-libbluray --enable-libflite --enable-libcelt --enable-libxvid --enable-libopenjpeg --enable-libmodplug --enable-libschroedinger --enable-libcdio --enable-libilbc

[ubitux]

Is the libmodplug build dynamically?

If libmodplug is only available statically this might be the cause of your issue. I'm not sure how to deal with this (except the workaround of building the shared libmodplug).

[chinshou]

libmodplug was built as static only.

CFLAGS=" -arch i386" CPPFLAGS=" -arch i386" LDFLAGS=" -arch i386" ./configure --prefix=/usr/darwin32 --enable-static --disable-shared

Because I want to build the dynamic build but without external dependency except libav libraries selves like the shared build on  http://ffmpeg.zeranoe.com/builds/ for windows.

[ubitux]

Well then maybe you could add --extra-libs=-lstdc++.

Another solution might be to try to detect when the library is available only statically and enable the pkg-config --static flag for that library only.

[richardpl]

I do not think this is ffmpeg fault.