Ticket #1761 (closed defect: invalid)
--enable-encoder=libx264 does nothing
| Reported by: | JunCTionS | Owned by: | |
|---|---|---|---|
| Priority: | normal | Component: | build system |
| Version: | git-master | Keywords: | libx264 |
| Cc: | Blocked By: | ||
| Blocking: | Reproduced by developer: | no | |
| Analyzed by developer: | no |
Description (last modified by cehoyos) (diff)
Summary of the bug:
How to reproduce:
When compiling (regardless of having libx264 installed or not)
% ./configure --enable-encoder=libx264
It will not give a "Unknown option" error (I believe it should) and it does not add libx264 to the list of encoders.
I now know the correct way to get libx264 is to use --enable-libx264. But was confused for a while.
here's a the config.log I get
ffmpeg version: N-44711-gf25d53d (that is what I get when I run ./version.sh after downloading the latest source with git)
built on Ubuntu 12.04 and 11.04
Change History
comment:1 Changed 9 months ago by cehoyos
- Keywords libx264 added
- Resolution set to invalid
- Status changed from new to closed
- Component changed from undetermined to build system
- Description modified (diff)
comment:2 Changed 9 months ago by JunCTionS
- Status changed from closed to reopened
- Resolution invalid deleted
Hmmm I wouldn't set this status to closed yet.
--enable-encoder=libx264 does nothing by itself. it should at least warn the user of that, as some (like myself) may think that it should be enough to enable the encoder (and anything necessary for it to do so).
If you disagree
comment:3 Changed 9 months ago by cehoyos
- Status changed from reopened to closed
- Resolution set to invalid
comment:4 follow-up: ↓ 5 Changed 9 months ago by michael
JunCTionS, if you want configure to print some warning in this case that explains the user that he used the wrong parameter and which is the correct one, such patch would certainly be welcome
comment:5 in reply to: ↑ 4 Changed 9 months ago by JunCTionS
Replying to michael:
JunCTionS, if you want configure to print some warning in this case that explains the user that he used the wrong parameter and which is the correct one, such patch would certainly be welcome
Meh... I'm rather new to programming and don't know where that would go (and I imagine someone familiar with the build system would do it in a flash).
I just thought I'd contribute by suggesting this change which IMO (as a low-level user) is a bug.
I take from this, that it's deemed unnecessary enough not to keep it open (even at low priority) until someone might stumble upon it and implement it.
The option is not unknown:
Please test "./configure --enable-libx264 --disable-encoders" and "./configure --enable-libx264 --disable-encoders --enable-encoder=libx264"