Ticket #2135 (closed enhancement: fixed)

Opened 5 months ago

Last modified 5 months ago

libutvideo wrapper compilation fails if utvideo is version 12.0.0

Reported by: qyot27 Owned by:
Priority: wish Component: avcodec
Version: git-master Keywords: libutvideo
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

The reason is because the RGB names have changed in 12.0.0, leaving the UTVF_RGB24/32_WIN names in the wrapper referring to labels that don't exist in the library.

I was able to fix it by changing the reference to UTVF_RGB24_WIN to UTVF_NFCC_BGR24_BU, and the reference to UTVF_RGB32_WIN to UTVF_NFCC_BGRX_BU and UTVF_NFCC_BGRA_BU in both the decoding and encoding wrappers. Not sure if both BGRX and BGRA should be defined for RGB32, though.

Change History

comment:1 Changed 5 months ago by cehoyos

  • Keywords libutvideo added; utvideo removed
  • Priority changed from normal to wish
  • Status changed from new to open
  • Type changed from defect to enhancement

If you have a patch, please send it to ffmpeg-devel.

If UTVF_NFCC_BGRA_BU is RGB32 or BGRA, BGRX should be 0RGB32 or BGR0 (this assumes that UTVF_NFCC_BGRA_BU is a format with transparency, and BGRX without).

comment:2 Changed 5 months ago by qyot27

There doesn't seem to be any kind of MKTAG/FourCC for the BGRX case (and ULRA explicitly says it's for BGRA), so I'll leave it out.

comment:3 Changed 5 months ago by richardpl

  • Status changed from open to closed
  • Resolution set to fixed

This appears to be fixed, if not please reopen bug with clarification what is still missing.

Note: See TracTickets for help on using tickets.