Ticket #2277 (closed defect: fixed)

Opened 3 months ago

Last modified 2 months ago

wrong comment in the alac.c

Reported by: chinshou Owned by:
Priority: minor Component: avcodec
Version: git-master Keywords: alac
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

alac.c has wrong comment:

  • 8bit initial history (14)
  • 8bit rice param limit (10)

it should be

  • 8bit initial history (10)
  • 8bit rice param limit (14)

see following code alacenc.c for correct init parameter value

Initialize default Rice parameters
s->rc.history_mult = 40;
s->rc.initial_history = 10;
s->rc.k_modifier = 14;

I have attached a patch for it

Attachments

alac.patch Download (499 bytes) - added by chinshou 3 months ago.

Change History

Changed 3 months ago by chinshou

comment:1 Changed 3 months ago by cehoyos

  • Keywords alac added
  • Status changed from new to open

Please send patches to ffmpeg-devel, they receive more attention on the mailing list.

comment:2 Changed 2 months ago by michael

  • Status changed from open to closed
  • Resolution set to fixed

Patch applied

Note: See TracTickets for help on using tickets.