tsc2 regression (green artifacts)

[ami_stuff]

there are visible green artifacts at the beginning of the video

(sorry, no time to do bin search)

 http://www.datafilehost.com/download-71fd0dac.html

C:\>ffmpeg -i tsc2_16bpp.avi out.avi
ffmpeg version N-50911-g9efcfbe Copyright (c) 2000-2013 the FFmpeg developers
  built on Mar 13 2013 21:26:48 with gcc 4.7.2 (GCC)
  configuration: --enable-gpl --enable-version3 --disable-w32threads --enable-av
isynth --enable-bzlib --enable-fontconfig --enable-frei0r --enable-gnutls --enab
le-libass --enable-libbluray --enable-libcaca --enable-libfreetype --enable-libg
sm --enable-libilbc --enable-libmp3lame --enable-libopencore-amrnb --enable-libo
pencore-amrwb --enable-libopenjpeg --enable-libopus --enable-librtmp --enable-li
bschroedinger --enable-libsoxr --enable-libspeex --enable-libtheora --enable-lib
twolame --enable-libvo-aacenc --enable-libvo-amrwbenc --enable-libvorbis --enabl
e-libvpx --enable-libx264 --enable-libxavs --enable-libxvid --enable-zlib
  libavutil      52. 19.100 / 52. 19.100
  libavcodec     55.  0.100 / 55.  0.100
  libavformat    55.  0.100 / 55.  0.100
  libavdevice    54.  4.100 / 54.  4.100
  libavfilter     3. 45.103 /  3. 45.103
  libswscale      2.  2.100 /  2.  2.100
  libswresample   0. 17.102 /  0. 17.102
  libpostproc    52.  2.100 / 52.  2.100
Input #0, avi, from 'tsc2_16bpp.avi':
  Duration: 00:00:12.63, start: 0.000000, bitrate: 5709 kb/s
    Stream #0:0: Video: tscc2 (tsc2 / 0x32637374), yuv444p, 320x240, 24 tbr, 24
tbn, 24 tbc
Output #0, avi, to 'out.avi':
  Metadata:
    ISFT            : Lavf55.0.100
    Stream #0:0: Video: mpeg4 (FMP4 / 0x34504D46), yuv420p, 320x240, q=2-31, 200
 kb/s, 24 tbn, 24 tbc
Stream mapping:
  Stream #0:0 -> #0:0 (tscc2 -> mpeg4)
Press [q] to stop, [?] for help
Input stream #0:0 frame changed from size:320x240 fmt:yuv444p to size:320x240 fm
t:yuv420p
[tscc2 @ 025c8000] Picture changed from size:320x240 fmt:yuv420p to size:320x240
 fmt:yuv444p in reget buffer()
Input stream #0:0 frame changed from size:320x240 fmt:yuv420p to size:320x240 fm
t:yuv444p
frame=   45 fps=0.0 q=3.8 size=     108kB time=00:00:01.87 bitrate= 470.4kbits/s
frame=  103 fps=0.0 q=6.0 size=     200kB time=00:00:04.29 bitrate= 381.2kbits/s
frame=  164 fps=109 q=7.2 size=     287kB time=00:00:06.83 bitrate= 344.2kbits/s
frame=  224 fps=112 q=6.1 size=     351kB time=00:00:09.33 bitrate= 308.2kbits/s
frame=  294 fps=118 q=4.6 size=     418kB time=00:00:12.25 bitrate= 279.6kbits/s
frame=  303 fps=118 q=5.2 Lsize=     434kB time=00:00:12.62 bitrate= 281.3kbits/
s
video:421kB audio:0kB subtitle:0 global headers:0kB muxing overhead 3.040613%

[cehoyos]

Regression since 32fdfdf

[michael]

cant reproduce (x86_64 linux)

[cehoyos]

I can reproduce the regression here with 29e0357 on Linux x86_64 with default compilation and with "--disable-yasm --disable-optimizations", not reproducible with --disable-asm, never reproducible on x86_32.

[cehoyos]

valgrind reports many uninitialized reads for the following commands, log file attached:

$ valgrind --malloc-fill=0x00 ffmpeg_g -i tsc2_16bpp.avi -t 1 out00.avi
$ valgrind --malloc-fill=0xff ffmpeg_g -i tsc2_16bpp.avi -t 1 outff.avi

The output files out00.avi and outff.avi look visually different.

[cehoyos]

Fixed by Anton Khirnov.