Ticket #543 (closed defect: fixed)

Opened 21 months ago

Last modified 20 months ago

cdg: set AV_PKT_FLAG_KEY

Reported by: gdesmott Owned by:
Priority: normal Component: avformat
Version: git-master Keywords: cdg
Cc: Blocked By:
Blocking: Reproduced by developer: yes
Analyzed by developer: no

Description

While integrating cdg support into gstreamer-ffmpeg (  https://bugzilla.gnome.org/show_bug.cgi?id=653493 ) I had to set the AV_PKT_FLAG_KEY on its packet to get it working.

I'm not a ffmpeg (or gst) expert but that seems like the right thing to do as this codec doesn't rely on key frames.

Attachments

0001-cdg.c-set-AV_PKT_FLAG_KEY-flag.patch Download (666 bytes) - added by gdesmott 21 months ago.
patch
a.cdg Download (1.8 MB) - added by gdesmott 20 months ago.
cdg file

Change History

Changed 21 months ago by gdesmott

patch

comment:1 Changed 21 months ago by gdesmott

comment:2 Changed 21 months ago by michael

  • Keywords cdg added
  • Status changed from new to closed
  • Version changed from unspecified to git-master
  • Resolution set to fixed
  • Reproduced by developer set

Thanks for pointing at this problem, ive succeeded to fix this in a way with which seeking works with my test file and only a subset of frames marked as keyframes.
Ill push it into master git after a bit more testing.
Also if you find files with which my fix doesnt work, please report them to us.

comment:3 Changed 20 months ago by gdesmott

I tried using cdg.c from efb1ce28b26b66f1f72f85fcdfaf16d7fe6519fe and that doesn't work properly.

gst does decode the video but some frames are missing and it's not synced with the audio.

My gst-ffmpeg patch is  https://bugzilla.gnome.org/show_bug.cgi?id=653493#c6
I'm attaching my test app and files as well.

Changed 20 months ago by gdesmott

cdg file

comment:4 Changed 20 months ago by gdesmott

I use: "gst-launch filesrc location=a.cdg ! ffdemux_cdg ! ffdec_cdgraphics ! ffmpegcolorspace ! ximagesink"

Note: See TracTickets for help on using tickets.