Ticket #895 (closed defect: fixed)

Opened 17 months ago

Last modified 15 months ago

sunras: support 32bpp

Reported by: ami_stuff Owned by:
Priority: normal Component: avcodec
Version: git-master Keywords: sunrast
Cc: Blocked By:
Blocking: Reproduced by developer: no
Analyzed by developer: no

Description

PIX_FMT_RGBA works correctly on big-endian, PIX_FMT_BGRA on little-endian

C:\>ffmpeg -i 32.ras
ffmpeg version N-36492-g7f83db3, Copyright (c) 2000-2012 the FFmpeg developers
  built on Jan  5 2012 01:57:12 with gcc 4.6.2
  configuration: --enable-gpl --enable-version3 --disable-w32threads --enable-ru
ntime-cpudetect --enable-avisynth --enable-bzlib --enable-frei0r --enable-libope
ncore-amrnb --enable-libopencore-amrwb --enable-libfreetype --enable-libgsm --en
able-libmp3lame --enable-libopenjpeg --enable-librtmp --enable-libschroedinger -
-enable-libspeex --enable-libtheora --enable-libvo-aacenc --enable-libvo-amrwben
c --enable-libvorbis --enable-libvpx --enable-libx264 --enable-libxavs --enable-
libxvid --enable-zlib
  libavutil      51. 34.100 / 51. 34.100
  libavcodec     53. 53.100 / 53. 53.100
  libavformat    53. 29.100 / 53. 29.100
  libavdevice    53.  4.100 / 53.  4.100
  libavfilter     2. 57.101 /  2. 57.101
  libswscale      2.  1.100 /  2.  1.100
  libswresample   0.  5.100 /  0.  5.100
  libpostproc    51.  2.100 / 51.  2.100
[sunrast @ 02645B60] invalid depth
[image2 @ 020E2320] Could not find codec parameters (Video: sunrast)
32.ras: could not find codec parameters

Attachments

32.rar Download (1.3 MB) - added by ami_stuff 17 months ago.
patchsunrast32bpp.diff Download (578 bytes) - added by cehoyos 17 months ago.

Change History

Changed 17 months ago by ami_stuff

comment:1 Changed 17 months ago by cehoyos

  • Status changed from new to open
  • Reproduced by developer set
  • Component changed from undetermined to avcodec
  • Priority changed from normal to wish
  • Version changed from unspecified to git-master
  • Keywords sunrast added
  • Type changed from defect to enhancement

Do you think the file is meant to be completely transparent? (It is imo likely that it actually should not be transparent at all.)
Could you try to encode an image that is part transparent, part opaque?

Changed 17 months ago by cehoyos

comment:2 Changed 17 months ago by ami_stuff

Sorry, I don't know how to create transparent sun raster (if it's possible), so I suggest supporting it without it.

Last edited 17 months ago by ami_stuff (previous) (diff)

comment:3 Changed 17 months ago by cehoyos

  • Blocked By set to 869

Mostly fixed, remaining issues depend on ticket #869.

comment:4 Changed 17 months ago by cehoyos

  • Blocked By changed from 869 to #869

comment:5 Changed 17 months ago by richardpl

IMHO blocking this bug by another, unrelated bug is pointless. This bug should and can be fixed without waiting for #869 to be fixed.

comment:6 Changed 17 months ago by cehoyos

  • Status changed from open to closed
  • Resolution set to fixed
  • Blocked By changed from #869 to 869

comment:7 Changed 15 months ago by richardpl

ImageMagick? displays wrong colors for this sample, what application created this file?

comment:8 Changed 15 months ago by richardpl

  • Status changed from closed to reopened
  • Reproduced by developer unset
  • Type changed from enhancement to defect
  • Blocked By 869 deleted
  • Priority changed from wish to normal
  • Resolution fixed deleted

Our decoder incorrectly decodes 32bit ras created with ImageMagick?.

Need more info about generated sample.

comment:9 Changed 15 months ago by cehoyos

  • Status changed from reopened to closed
  • Resolution set to fixed

Attached sample decodes visually incorrect now, but decoder matches what Gimp, ImageMagick? and xview do and what the terse specification indicates.

Note: See TracTickets for help on using tickets.