[FFmpeg-devel] [PATCH 2/6] avutil/csp: eliminate redundant branch

Ronald S. Bultje rsbultje at gmail.com
Mon Nov 25 16:07:50 EET 2024


Hi,

On Mon, Nov 25, 2024 at 8:16 AM Niklas Haas <ffmpeg at haasn.xyz> wrote:

> From: Niklas Haas <git at haasn.dev>
>
> ---
>  libavutil/csp.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/libavutil/csp.c b/libavutil/csp.c
> index 7ef822c60b..3dd7bc2562 100644
> --- a/libavutil/csp.c
> +++ b/libavutil/csp.c
> @@ -290,11 +290,7 @@ static const av_csp_trc_function
> trc_funcs[AVCOL_TRC_NB] = {
>
>  av_csp_trc_function av_csp_trc_func_from_id(enum
> AVColorTransferCharacteristic trc)
>  {
> -    av_csp_trc_function func;
>      if (trc >= AVCOL_TRC_NB)
>          return NULL;
> -    func = trc_funcs[trc];
> -    if (!func)
> -        return NULL;
> -    return func;
> +    return trc_funcs[trc];
>  }
>

How does this deal with users calling this function
with AVCOL_TRC_RESERVED0, AVCOL_TRC_UNSPECIFIED or AVCOL_TRC_RESERVED?

Ronald


More information about the ffmpeg-devel mailing list