[Ffmpeg-cvslog] CVS: ffmpeg/libavcodec vp3.c,1.64,1.65

[Diego Biurrun]

On Sat, May 21, 2005 at 01:02:01PM +0200, Michael Niedermayer wrote:
> 
> On Saturday 21 May 2005 12:03, Diego Biurrun wrote:
> > On Sat, May 21, 2005 at 09:35:17AM +0200, Michael Niedermayer CVS wrote:
> > > Modified Files:
> > > 	vp3.c
> > > Log Message:
> > > disable broken loop filter optimization
> > > melanson please test your optimizations before commiting!
> >
> > I cannot see any artifacts on my samples, 
> 
> i can, and the md5 of the output changes which is what matters, the md5 must 
> not change due to optimizations unless its fully understood why
> if this rule is ignored you quickly end up with a deeply broken mess which is 
> very hard to debug and fix

Of course, I did not mean to imply something different, I just did not
notice anything visible.

> > but performance actually seems 
> > to go down with the optimizations enabled...
> 
> you mean with this one too? the unconditional change to decoding all 3 planes 
> at once instead of sequantially even if the user app doesnt support slices 
> did already reduce the speed ...

Yes, I changed your #if 0 to #if 1 for a quick speed comparison.  Speed
went down instead of up.  I tested with MPlayer without any further
tweaking of the code, so I may easily have overlooked some necessary
changes.

Diego