[Ffmpeg-cvslog] CVS: ffmpeg/libavcodec cabac.h, 1.13, 1.14 h264.c, 1.201, 1.202

[Michael Niedermayer]

Hi

On Sat, Apr 29, 2006 at 02:47:28PM -0700, Loren Merritt wrote:
> On Sat, 29 Apr 2006, matthieu castet wrote:
> 
> >Loren Merritt CVS wrote:
> >>Update of /cvsroot/ffmpeg/ffmpeg/libavcodec
> >>In directory mail:/var2/tmp/cvs-serv6466
> >>
> >>Modified Files:
> >>	cabac.h h264.c Log Message:
> >>don't force asserts in release builds. 2% faster h264.
> >
> >Wasn't a policy of ffmpeg to always keep assert enabled ?
> 
> I see asserts enabled in dvdsubenc, flac, motion_est, vorbis, qdm2, snow, 
> svq1, vc9. And disabled in all the other codecs.

the idea was that asserts should be always enabled for cases where speed
doesnt matter, yeah we should have a
av_assert() (not often executed, failure doesn lead to security issues)
av_assert_security() (failure could lead to exploit)
av_assert_speedcritical() (often executed)

or something like that

[...]

-- 
Michael

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is