[Ffmpeg-cvslog] r5872 - trunk/configure

[Michael Niedermayer]

Hi

On Mon, Jul 31, 2006 at 10:43:23PM -0400, Rich Felker wrote:
> On Mon, Jul 31, 2006 at 08:58:57PM +0200, mru wrote:
> > Author: mru
> > Date: Mon Jul 31 20:58:56 2006
> > New Revision: 5872
> > 
> > Modified:
> >    trunk/configure
> > 
> > Log:
> > ignore explicit #warnings in compiler tests
> > 
> > 
> > Modified: trunk/configure
> > ==============================================================================
> > --- trunk/configure	(original)
> > +++ trunk/configure	Mon Jul 31 20:58:56 2006
> > @@ -214,7 +214,7 @@
> >  }
> >  
> >  check_cmd(){
> > -    "$@" 2>&1 | tee -a $logfile | { ! grep -q .; }
> > +    "$@" 2>&1 | tee -a $logfile | { ! grep -E -q -v '#warning|^In file'; }
> >  }
> 
> If you ask me, grepping the output sounds _extremely_ fragile. What
> compiles can you not trust exit status for? IMO it would be much safer
> to detect the few specific broken ones and wrap them with a script
> that fixes the exit status, than to risk breaking things on all sorts
> of non-broken platforms..

what about checking if the compiler generated some executable? or do
i miss something here (i didnt really follow this issue/thread ...)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is