[Ffmpeg-cvslog] Re: r5886 - trunk/libavformat/gxf.c

[Baptiste Coudurier]

Hi

Reimar D?ffinger wrote:
> Hello,
> On Wed, Aug 02, 2006 at 10:45:10AM +0200, bcoudurier wrote:
>> Log:
>> do not set unneeded fourcc
> [...]
>>          case 22:
>>          case 23:
>>              st->codec->codec_type = CODEC_TYPE_VIDEO;
>>              st->codec->codec_id = CODEC_ID_MPEG1VIDEO;
>> -            st->codec->codec_tag = MKTAG('M', 'P', 'G', '1');
>>              break;
>>          case 9:
>>              st->codec->codec_type = CODEC_TYPE_AUDIO;
> 
> Hmm, didn't see before, but any reason why you didn't remove codec_tag
> for the audio codecs? I only have PCM samples to test, but I think there
> is no reason to keep them, and I like being consistent.
> 

Oh, sorry. Audio tags didn't catch my attention. Im fixing right now.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312