[Ffmpeg-cvslog] Re: r6064 - trunk/libavformat/mov.c

[Baptiste Coudurier]

Hi

Roman Shaposhnick wrote:
> On Thu, Aug 24, 2006 at 10:28:12AM +0200, bcoudurier wrote:
>> Author: bcoudurier
>> Date: Thu Aug 24 10:28:11 2006
>> New Revision: 6064
>>
>> Modified:
>>    trunk/libavformat/mov.c
>>
>> Log:
>> support vdva fourcc (dv + dv audio in mov)
>>
>> Modified: trunk/libavformat/mov.c
>> ==============================================================================
>> --- trunk/libavformat/mov.c	(original)
>> +++ trunk/libavformat/mov.c	Thu Aug 24 10:28:11 2006
>> @@ -24,6 +24,7 @@
>>  #include "avformat.h"
>>  #include "riff.h"
>>  #include "isom.h"
>> +#include "dv.h"
>>  
>>  #ifdef CONFIG_ZLIB
>>  #include <zlib.h>
>> @@ -144,6 +145,8 @@
>>      { CODEC_ID_AC3, MKTAG('m', 's', 0x20, 0x00) }, /* Dolby AC-3 */
>>      { CODEC_ID_ALAC,MKTAG('a', 'l', 'a', 'c') }, /* Apple Lossless */
>>      { CODEC_ID_QDM2,MKTAG('Q', 'D', 'M', '2') }, /* QDM2 */
>> +    { CODEC_ID_DVAUDIO, MKTAG('v', 'd', 'v', 'a') },
>> +    { CODEC_ID_DVAUDIO, MKTAG('d', 'v', 'c', 'a') },
> 
>   I have mixed feelings about this. On one hand CODEC_ID_DVAUDIO looks
> kind of silly as a standalone codec. On the other hand, may be implementing
> just the *DECODER* wouldn't be such a bad idea given that all this crap
> is still out there for us to decode.
> 
> What do you guys think ?
> 

I think that would be a good idea. The decoder would extract just audio
in the frame and that would simplify at least mov demuxing.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312