[Ffmpeg-cvslog] r7184 - trunk/libavformat/westwood.c

[Michael Niedermayer]

Hi

On Fri, Dec 01, 2006 at 08:02:14AM +0200, Kostya wrote:
> On Wed, Nov 29, 2006 at 08:53:44PM +0100, Michael Niedermayer wrote:
> > Hi
> > 
> > On Wed, Nov 29, 2006 at 06:43:08AM +0100, kostya wrote:
> > > Author: kostya
> > > Date: Wed Nov 29 06:42:59 2006
> > > New Revision: 7184
> > > 
> > > Modified:
> > >    trunk/libavformat/westwood.c
> > > 
> > > Log:
> > > Better VQA demuxer
> > [...]
> > > +    while (get_buffer(pb, preamble, VQA_PREAMBLE_SIZE) == VQA_PREAMBLE_SIZE) {
> > > +        chunk_type = BE_32(&preamble[0]);
> > > +        chunk_size = BE_32(&preamble[4]);
> > > +        skip_byte = chunk_size & 0x01;
> > > +
> > > +        if ((chunk_type == SND1_TAG) || (chunk_type == SND2_TAG) || (chunk_type == VQFR_TAG)) {
> > > +
> > > +            if (av_new_packet(pkt, chunk_size))
> > > +                return AVERROR_IO;
> > > +            ret = get_buffer(pb, pkt->data, chunk_size);
> > > +            if (ret != chunk_size) {
> > > +                av_free_packet(pkt);
> > > +                return AVERROR_IO;
> > > +            }
> > > +
> > > +            if (chunk_type == SND2_TAG) {
> > > +                pkt->stream_index = wsvqa->audio_stream_index;
> > > +
> > > +                pkt->pts = 90000;
> > > +                pkt->pts *= wsvqa->audio_frame_counter;
> > > +                pkt->pts /= wsvqa->audio_samplerate;
> > 
> > this is wrong like the rest of the related code which was already in
> > westwood.c, just grep for 90000, all the matching lines are wrong
> 
> Do you mean it should be done by calling av_set_pts_info() with correct
> parameters 

yes


> and not touching pkt->pts? If so, I may fix it.

if there are no timestamps / no seeking is possible then setting ->pts
doesnt make sense ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is