[Ffmpeg-cvslog] r7204 - trunk/libavcodec/motion_est_template.c

[Michael Niedermayer]

Hi

On Sat, Dec 02, 2006 at 01:15:52PM -0700, Loren Merritt wrote:
> On Sat, 2 Dec 2006, michael wrote:
> 
> >Author: michael
> >Date: Sat Dec  2 11:45:51 2006
> >New Revision: 7204
> >
> >Modified:
> >  trunk/libavcodec/motion_est_template.c
> >
> >Log:
> >hexagon search
> >	dia_size=512 + hexagon size (513 is the normal one used in h264)
> 
> x264's hexagon is radius 2, so based on that description I would expect it 
> to be dia_size=514. But I see from the code that size is doubled, so you 
> can't specify odd radius. (radius 1 is meaningless, it would be the same 
> as diamond. but radius 3 could be used.)

yes but such a size 3 hexagon would be less efficient i think, as fewer 
points would overlap (all just guessing i didnt really look at this ...)

also maybe we should rather reduce the size by a factor of 2 instead of -1
each time it ends in a local minimum? actually this was what i wanted to
implement seems i implemented something else ;)

and feel free to change the hex & umh ME code any way you see fit if you 
want

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is