[Ffmpeg-cvslog] r7213 - trunk/libavcodec/utils.c

[Diego Biurrun]

On Sun, Dec 03, 2006 at 01:16:24AM +0100, Michael Niedermayer wrote:
> 
> On Sat, Dec 02, 2006 at 07:58:20PM +0100, diego wrote:
> > 
> > Log:
> > Fill in some missing AVOption descriptions.
> > patch by V?ctor Paesa, wzrlpy arsystel com
> 
> [...]
> > +{"faan", "floating point AAN", 0, FF_OPT_TYPE_CONST, FF_DCT_FAAN, INT_MIN, INT_MAX, V|E, "dct"},
> 
> AAN= Arai, Agui, and Nakajima
> 
> so somehow this sounds funny
> 
> floating point Arai, Agui, and Nakajima
> somehing tells me DCT should be at the end of that string ...

Fixed.

> > -{"idct", NULL, OFFSET(idct_algo), FF_OPT_TYPE_INT, DEFAULT, 0, INT_MAX, V|E|D, "idct"},
> > +{"idct", "use interlaced DCT", OFFSET(idct_algo), FF_OPT_TYPE_INT, DEFAULT, 0, INT_MAX, V|E|D, "idct"},
> 
> umm close

Fixed.

> > +{"mb_qmin", "obsolete, use vqmin", OFFSET(mb_qmin), FF_OPT_TYPE_INT, DEFAULT, INT_MIN, INT_MAX, V|E},
> > +{"mb_qmax", "obsolete, use vqmax", OFFSET(mb_qmax), FF_OPT_TYPE_INT, DEFAULT, INT_MIN, INT_MAX, V|E},
> 
> what is vqmin/vqmax? my grep doesnt find them in ffmpeg 

Then the MPlayer man page is buggy regarding this:

  mbqmin=<1\-31>
    obsolete, use vqmin

  mbqmax=<1\-31>
    obsolete, use vqmax

Diego