[Ffmpeg-cvslog] r7234 - trunk/libavformat/utils.c

Måns Rullgård mru
Wed Dec 6 17:23:48 CET 2006


Baptiste Coudurier said:
> Michael Niedermayer wrote:
>> Hi
>>
>> On Wed, Dec 06, 2006 at 04:53:29PM +0100, Reimar D?ffinger wrote:
>>> Hello,
>>> On Wed, Dec 06, 2006 at 04:46:12PM +0100, bcoudurier wrote:
>>>> -    pkt->pts &= pts_mask;
>>>> -    pkt->dts &= pts_mask;
>>>> +    if( pkt->pts != AV_NOPTS_VALUE ) {
>>>> +        pkt->pts &= pts_mask;
>>>> +    }
>>>> +    if( pkt->dts != AV_NOPTS_VALUE ) {
>>>> +        pkt->dts &= pts_mask;
>>>> +    }
>>> Am I the only one who would have preferred this without the extra {}?
>>
>> no, but i thought it wasnt worth the complaint and resubmit and rereview
>>
>
> I would have also preferred. Should I clean, should we set a policy ?

I don't care about the extraneous braces {}, but *please* remove the spaces just
inside the parens ().  I can't stand that style.

-- 
M?ns Rullg?rd
mru at inprovide.com




More information about the ffmpeg-cvslog mailing list