[Ffmpeg-cvslog] r7246 - trunk/libavcodec/avcodec.h

[Baptiste Coudurier]

Panagiotis Issaris wrote:
> Hi,
> 
> On Tue, 2006-12-19 at 10:54 +0100, Baptiste Coudurier wrote:
>> Hi
>> 
>> takis wrote:
>>> Author: takis Date: Thu Dec  7 16:59:42 2006 New Revision: 7246
>>> 
>>> Modified: trunk/libavcodec/avcodec.h
>>> 
>>> Log: Add codec ID for a native H.264 encoder.
>>> 
>>> 
>>> Modified: trunk/libavcodec/avcodec.h 
>>> ==============================================================================
>>>  --- trunk/libavcodec/avcodec.h	(original) +++
>>> trunk/libavcodec/avcodec.h	Thu Dec  7 16:59:42 2006 @@ -149,6
>>> +149,7 @@ CODEC_ID_TIERTEXSEQVIDEO, CODEC_ID_TIFF, CODEC_ID_GIF, 
>>> +    CODEC_ID_FFH264,
>>> 
>> We were discussing that issue, why did you add it ?
> Well, frankly, because the maintainer of that file (Michael) had 
> accepted that hunk of the patch and it seemed the following
> discussion had halted without a clear decision.

Well, in that case, we should had a clear statement, asking again would
not have hurt anything.

>> Codec id are for codecs, not a way to distinguish between 
>> decoders/encoders IMHO.
> How about CODEC_ID_MPEG2VIDEO and CODEC_ID_MPEG2VIDEO_XVMC or 
> CODEC_ID_MPEG4 and the CODEC_ID_MSMPEG* variants of CODEC_ID_WMV3 and
>  CODEC_ID_VC1?
> 
> Aren't they different implementations of the same standard? (MPEG2 in
>  the first case, MPEG-4 in the second and VC1 in the third)
> 

Don't know much about differences, but I guess bitstream contains
differences according to lavc code (msmpeg4.c), so again I guess those
are variants of one standard, not different implementations.
Again maybe Im completely wrong.

FFH264 is just a different implementation of CODEC_ID_H264, and should
not have another id IMHO. Also since lavc API allows to choose
decoder/encoder by name instead of id, though ffmpeg.c only uses id.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312