[Ffmpeg-cvslog] Re: r5468 - trunk/libavformat/mov.c

[Michael Niedermayer]

Hi

On Sun, Jun 25, 2006 at 06:41:11PM +0200, Baptiste Coudurier wrote:
> Hi
> 
> Michael Niedermayer wrote:
> > [...]
> >> - to stream copy audio tracks I need to know codec->frame_size to set
> >> 'stts' correctly. I can either assign it in the demuxer, from the
> >> original 'stts' atom, but it sometimes contains more than one value, or
> >> assume it according to codec used, AAC uses 1024, AMR 160, PCM 1.
> >> What do you think ?
> > 
> > i think that the timebase (or samplerate or samplerate/frame_size if known)
> > and AVPacket.dts should be used this reminds me that the mov muxer doesnt 
> > work with non constant fps videos ...
> > 
> 
> I worked on vfr muxing, it seems to work, based on dts differences, but
> I still have a problem with audio stream copy case.
> 
> I don't have a method to compute last packet duration.
> 
> Good way is to use pkt->duration but in case of stream copy, that
> duration is 0, and frame_size is 0 too. Do you have any idea ?

hmm, its not 0 here on the few cases i tried ...
which audio codec are you using?
compute_pkt_fields() and compute_pkt_fields2() should fill in the duration if
its missing ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is