[Ffmpeg-cvslog] CVS: ffmpeg/libavutil common.h,1.161,1.162

[Dominik 'Rathann' Mierzejewski]

On Monday, 06 March 2006 at 11:05, Diego Biurrun CVS wrote:
> Update of /cvsroot/ffmpeg/ffmpeg/libavutil
> In directory mail:/var2/tmp/cvs-serv4714/libavutil
> 
> Modified Files:
> 	common.h 
> Log Message:
> Proper mangling information for symbols in OS X Mach-O shared objects.
> patch by Samuel Hocevar, sam ..at.. zoy ..dot.. org
> 
> 
> Index: common.h
> ===================================================================
> RCS file: /cvsroot/ffmpeg/ffmpeg/libavutil/common.h,v
> retrieving revision 1.161
> retrieving revision 1.162
> diff -u -d -r1.161 -r1.162
> --- common.h	30 Jan 2006 00:22:41 -0000	1.161
> +++ common.h	6 Mar 2006 10:04:59 -0000	1.162
> @@ -261,6 +261,8 @@
>          defined(__OS2__) || (defined (__OpenBSD__) && !defined(__ELF__))
>  #        if defined(ARCH_X86_64) && defined(PIC)
>  #            define MANGLE(a) "_" #a"(%%rip)"
> +#        elif defined(CONFIG_DARWIN)
> +#            define MANGLE(a) "_" #a
>  #        else
>  #            define MANGLE(a) "_" #a
>  #        endif

Maybe it's a stupid question, but how does that change anything?
Without this change, wouldn't the preprocessor fall through to
the last case which is identical to what you added?

R.

-- 
MPlayer developer and RPMs maintainer: http://rpm.greysector.net/mplayer/
There should be a science of discontent. People need hard times and oppression
to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan