[Ffmpeg-cvslog] CVS: ffmpeg/libavformat dv1394.c,1.19,1.20

Diego Biurrun diego
Thu Mar 9 10:09:49 CET 2006


On Thu, Mar 09, 2006 at 09:30:47AM +0100, Luca Abeni wrote:
> 
> On Wed, 2006-03-08 at 19:40 +0100, Diego Biurrun wrote:
> [...]
> > > Just a little question: why an "av_log(context, AV_LOG_ERROR, ...)"
> > > inside an "#ifdef DV1394_DEBUG"?
> > > AV_LOG_ERROR seems to imply that the message is critical, but on the
> > > other hand it can be missed if DV1394_DEBUG is not defined...
> > > 
> > > Maybe an "av_log(context, AV_LOG_DEBUG, ...)" (without #idef?) would be
> > > more appropriate?
> > 
> > Yes, feel free to fix...
> Well, I see that you've been faster than me... ;-)

Since I committed I should really be the one cleaning up ;)

> Anyway, I was asking just because of my curiosity.

Thanks for reviewing commits.

Diego





More information about the ffmpeg-cvslog mailing list