[Ffmpeg-cvslog] CVS: ffmpeg/libavformat mov.c,1.122,1.123

[Rich Felker]

On Sat, Mar 11, 2006 at 08:48:33PM +0000, M?ns Rullg?rd wrote:
> Rich Felker <dalias at aerifal.cx> writes:
> 
> > On Sat, Mar 11, 2006 at 07:43:13PM +0100, Baptiste Coudurier CVS wrote:
> >> Update of /cvsroot/ffmpeg/ffmpeg/libavformat
> >> In directory mail:/var2/tmp/cvs-serv19106/libavformat
> >> 
> >> Modified Files:
> >> 	mov.c 
> >> Log Message:
> >> fix a warning when DEBUG is defined
> >> 
> >> Index: mov.c
> >> ===================================================================
> >> RCS file: /cvsroot/ffmpeg/ffmpeg/libavformat/mov.c,v
> >> retrieving revision 1.122
> >> retrieving revision 1.123
> >> diff -u -d -r1.122 -r1.123
> >> --- mov.c	11 Mar 2006 11:30:07 -0000	1.122
> >> +++ mov.c	11 Mar 2006 18:43:10 -0000	1.123
> >> @@ -779,7 +779,7 @@
> >>      if (st->codec->extradata) {
> >>          strcpy(st->codec->extradata + 4, "alac"); // fake
> >>          get_buffer(pb, st->codec->extradata + 8, 36 - 8);
> >> -        dprintf("Reading alac %Ld  %s\n", st->codec->extradata_size, (char*)st->codec->extradata);
> >> +        dprintf("Reading alac %d  %s\n", st->codec->extradata_size, (char*)st->codec->extradata);
> >
> > This is INCORRECT! Neither ISO C nor POSIX/SUSv3 define a %Ld format
> > specifier. You meant either %ld, %lld, or one of the PRI*d macros, and
> > I'm not sure which, but please fix this!
> 
> AVCodecContext.extradata_size is an int, so %d is correct.  Are you
> saying that the bug was buggy or something?

Umm, give me a few thousand litres of cola and then some sleep. I read
the patch backwards! :( And thanks Baptiste for fixing it.

Rich