[Ffmpeg-cvslog] Re: CVS: ffmpeg qt-faststart.c,1.5,1.6

[Baptiste COUDURIER]

Mike Melanson wrote:
> Baptiste Coudurier CVS wrote:
> 
>> Update of /cvsroot/ffmpeg/ffmpeg
>> In directory mail:/var2/tmp/cvs-serv8734
>>
>> Modified Files:
>>     qt-faststart.c Log Message:
>>
>>> 2GB file fix
>>
>>
>>
>> Index: qt-faststart.c
>> ===================================================================
>> RCS file: /cvsroot/ffmpeg/ffmpeg/qt-faststart.c,v
>> retrieving revision 1.5
>> retrieving revision 1.6
>> diff -u -d -r1.5 -r1.6
>> --- qt-faststart.c    16 Mar 2006 16:37:05 -0000    1.5
>> +++ qt-faststart.c    16 Mar 2006 23:57:40 -0000    1.6
>> @@ -99,7 +99,7 @@
>>          if (fread(atom_bytes, ATOM_PREAMBLE_SIZE, 1, infile) != 1) {
>>              break;
>>          }
>> -        atom_size = BE_32(&atom_bytes[0]);
>> +        atom_size = (uint32_t)BE_32(&atom_bytes[0]);
>>          atom_type = BE_32(&atom_bytes[4]);
>>  
>>          if ((atom_type != FREE_ATOM) &&
> 
> 
>     You ran all those other patches by me first, why not this one? This
> strikes me as unnecessary. BE_32 should do the right thing without
> extraneous casting.
> 

Ah sorry Mike, I did not want to annoy you with that small fix. Well,
after some testing, it seems not. I get negative sizes for mdat atoms >
2gb but <4gb.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312