[Ffmpeg-cvslog] CVS: ffmpeg/tests libav.regression.ref, 1.91, 1.92 regression.sh, 1.93, 1.94

[Michael Niedermayer]

Hi

On Fri, Mar 17, 2006 at 02:30:09PM +0100, Diego Biurrun wrote:
> On Fri, Mar 17, 2006 at 02:35:13AM +0100, Michael Niedermayer wrote:
> > 
> > On Fri, Mar 17, 2006 at 01:47:50AM +0100, Diego Biurrun CVS wrote:
> > > 
> > > Modified Files:
> > > 	libav.regression.ref regression.sh 
> > > Log Message:
> > > Disable the NUT (de)muxer until it has been synced with the specification.
> > > 
> > > --- libav.regression.ref	2 Mar 2006 20:44:35 -0000	1.91
> > > +++ libav.regression.ref	17 Mar 2006 00:47:48 -0000	1.92
> > > @@ -25,9 +25,6 @@
> > >  63e05396e2d52135c4025ce14eb090a9 *./data/b-libav.mov
> > >  369893 ./data/b-libav.mov
> > >  ./data/b-libav.mov CRC=0x48f5a90d
> > > -8bf16d40a2ec19fa36b124a928e47e23 *./data/b-libav.nut
> > > - 332358 ./data/b-libav.nut
> > > -./data/b-libav.nut CRC=0xccab3a27
> > >  2cc647904d3cca01703f36056b9d3f42 *./data/b-libav.dv
> > >  3600000 ./data/b-libav.dv
> > >  ./data/b-libav.dv CRC=0xa6b8b635
> > 
> > i think i said the nut regression test must not be removed/fail
> > it will only make it harder to adapt nut later, as it might decay
> > similar to ffserver ...
> 
> Umm, I interpreted your words in a slightly different way then.  Let me
> explain.
> 
> I understood that you did not want the regression tests to fail due to
> disabling NUT.  They don't fail right now.  I removed the above lines
> from libav.regression.ref because it is not possible to comment something
> out in this file.  I thought that if somebody reenables NUT the numbers
> will have to be updated anyway, so I might as well just remove them.
> 
> I can add a comment to the effect of "Don't forget to reenable
> regression test when you reenable NUT." to libavformat/allformats.h,
> this should take care of the danger of regression tests being forgotten.

do what you like in nut.c but dont modify libav.regression.ref, regression.sh
 = please reverse this change = dont disable NUT = dont disable the NUT
regression test

you can, if you like to add something like

if(filesize of file we have != filesize of the file used in the regression test){
    av_log(..., "NUT is has not been updated to the latest spec and due to
                 that has been disabled, thank you for using ffmpeg!\n");
    return -1;
}

[...]

-- 
Michael