[Ffmpeg-cvslog] r6963 - trunk/libavformat/riff.c

[Michael Niedermayer]

Hi

On Sat, Nov 11, 2006 at 01:22:08AM +0000, M?ns Rullg?rd wrote:
> michael <subversion at mplayerhq.hu> writes:
> 
> > Author: michael
> > Date: Sat Nov 11 01:29:49 2006
> > New Revision: 6963
> >
> > Modified:
> >    trunk/libavformat/riff.c
> >
> > Log:
> > libnut uses "MP3 " for mp3
> >
> > Modified: trunk/libavformat/riff.c
> > ==============================================================================
> > --- trunk/libavformat/riff.c	(original)
> > +++ trunk/libavformat/riff.c	Sat Nov 11 01:29:49 2006
> > @@ -200,6 +200,7 @@
> >      // for NuppelVideo (nuv.c)
> >      { CODEC_ID_PCM_S16LE, MKTAG('R', 'A', 'W', 'A') },
> >      { CODEC_ID_MP3, MKTAG('L', 'A', 'M', 'E') },
> > +    { CODEC_ID_MP3, MKTAG('M', 'P', '3', ' ') },
> 
> Nooooo.  We were trying to get rid of those invalid bogus tags from
> riff.c.  Don't add more of them.

nut per spec uses the avi-riff tags to identify codecs, libnut uses
"MP3 " ...
ask oded why
but the nut tags do belong in riff.c IMO, furthermore there is no harm
from this wav/avi cant use them anyway as they are too long, also they
are at the end so they wont be selected by default ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is