[Ffmpeg-cvslog] r8788 - trunk/tests/Makefile

[Måns Rullgård]

Oded Shimon <ods15 at ods15.dyndns.org> writes:

> On Sun, Apr 22, 2007 at 08:30:14PM +0200, michael wrote:
>> Author: michael
>> Date: Sun Apr 22 20:30:14 2007
>> New Revision: 8788
>> 
>> Log:
>> ensure that seek_test is rebuild if any of the libs changed
>> 
>> 
>> Modified:
>>    trunk/tests/Makefile
>> 
>> Modified: trunk/tests/Makefile
>> ==============================================================================
>> --- trunk/tests/Makefile	(original)
>> +++ trunk/tests/Makefile	Sun Apr 22 20:30:14 2007
>> @@ -82,8 +82,10 @@ audiogen$(EXESUF): audiogen.c
>>  tiny_psnr$(EXESUF): tiny_psnr.c
>>  	$(CC) $(LDFLAGS) $(CFLAGS) -o $@ $<
>>  
>> +LIBAV = ../libavformat/libavformat.a ../libavcodec/libavcodec.a ../libavutil/libavutil.a
>> +
>>  #FIXME cleanup shit below
>> -seek_test$(EXESUF): seek_test.c
>> +seek_test$(EXESUF): seek_test.c $(LIBAV)
>>  	$(CC) $(LDFLAGS) $(CFLAGS) -DHAVE_AV_CONFIG_H -I.. -I$(SRC_PATH)/libavformat/ -I$(SRC_PATH)/libavcodec/ -I$(SRC_PATH)/libavutil/ -o $@ $< $(SRC_PATH)/libavformat/libavformat.a $(SRC_PATH)/libavcodec/libavcodec.a $(SRC_PATH)/libavutil/libavutil.a $(EXTRALIBS)
>
> May I suggest...
>
> LIBAV = $(SRC_PATH)/libavformat/libavformat.a $(SRC_PATH)/libavcodec/libavcodec.a $(SRC_PATH)/libavutil/libavutil.a
> seek_test$(EXESUF): seek_test.c $(LIBAV)
> 	$(CC) $(LDFLAGS) $(CFLAGS) -DHAVE_AV_CONFIG_H -I.. -I$(SRC_PATH)/libavformat/ -I$(SRC_PATH)/libavcodec/ -I$(SRC_PATH)/libavutil/ -o $@ $^ $(EXTRALIBS)
>
> Seems more correct and logical...

No, that's wrong.  The libs are not in SRC_PATH if you build outside
the source tree.

-- 
M?ns Rullg?rd
mans at mansr.com