[FFmpeg-cvslog] r9848 - trunk/libavcodec/ac3dec.c

[Michael Niedermayer]

Hi

On Fri, Aug 03, 2007 at 11:24:57AM +0200, Benjamin Larsson wrote:
> Michael Niedermayer skrev:
> > Hi
> >
> > On Thu, Aug 02, 2007 at 06:08:49PM +0200, Benjamin Larsson wrote:
> >   
> >> Michael Niedermayer skrev:
> >>     
> >>>> Sure looks ok, this will save us some future bugreports.
> >>>>     
> >>>>         
> >>> droping win32 support saves us from more
> >>> also if i had to choose between drping suport for a buggy gcc on a buggy os
> >>> vs. some senseless double memcpy() then i would instantly choose the first
> >>>
> >>> please do not suggest to add such terrible hacks for things which have
> >>> several clean soltions like droping win32 support, disabling SSE on win32, 
> >>> requireing gcc 4.2 and realignung the stack on win32, decoding data
> >>> interleaved, ...
> >>>   
> >>>       
> >> I remeber adding one of those terrible hacks to the wma decoder. Should 
> >> it be reverted 
> >>     
> >
> > i searched for lars & wma but the 2 matches didnt look like what you
> > describe ...
> >   
> http://svn.mplayerhq.hu/ffmpeg/trunk/libavcodec/wmadec.c?r1=7318&r2=7317&pathrev=7318
> 
> That change moves 2 buffers to the context just to ensure alignment when 
> using gcc versions < 4.

iam not totally happy about it but its better than doing an extra memcpy()

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070803/5ea63b86/attachment.pgp>