[FFmpeg-cvslog] r11225 - trunk/libavformat/avformat.h

[Michael Niedermayer]

On Mon, Dec 17, 2007 at 02:14:41AM +0000, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > On Sun, Dec 16, 2007 at 11:40:05PM +0000, M?ns Rullg?rd wrote:
> >> Diego Biurrun <diego at biurrun.de> writes:
> >> 
> >> > On Sun, Dec 16, 2007 at 10:52:23PM +0000, M?ns Rullg?rd wrote:
> >> >> Michael Niedermayer <michaelni at gmx.at> writes:
> >> >> 
> >> >> > On Sun, Dec 16, 2007 at 06:22:09PM +0100, Diego Biurrun wrote:
> >> >> >> On Sat, Dec 15, 2007 at 05:54:59PM +0100, michael wrote:
> >> >> >> > 
> >> >> >> > Log:
> >> >> >> > document how to free the result of av_alloc_format_context()
> >> >> >> > 
> >> >> >> > --- trunk/libavformat/avformat.h	(original)
> >> >> >> > +++ trunk/libavformat/avformat.h	Sat Dec 15 17:54:58 2007
> >> >> >> > @@ -569,7 +569,11 @@ int av_open_input_file(AVFormatContext *
> >> >> >> > +/**
> >> >> >> > + * Allocate an AVFormatContext.
> >> >> >> > + * can be freed with av_free() but dont forget to free everything you
> >> >> >> > + * explicitly allocated as well!
> >> >> >> 
> >> >> >> Could you please make an effort to avoid obvious misspellings
> >> >> >> ("dont")?  It took some work to fix these things up in FFmpeg
> >> >> >> and it would be a pity to let it go to waste again.
> >> >> >
> >> >> > feel free to improve the precommit check script
> >> >> 
> >> >> I have to say, this attitude of yours is starting to get quite tiresome.
> >> >
> >> > Very much so.  I don't understand why you are such a complete
> >> > perfectionist about what code is acceptable for FFmpeg and at the
> >> > same time disregard the quality of the (Doxygen) documentation.
> >
> > because "dont" is as readable with as well as without some little
> > speck between n and t, buggy, slow, bloated, ... code though has a
> > quite noticeable effect, take a look at our bugtracker how many bugs
> > are there about spelling and grammer and how many are there about
> > other things
> 
> Am I the only one who struggles to read Michaels streams of words,
> totally void of all structure and punctuation?

begladiputtedspacesinthere


> 
> > i prefer to concentrate on fixing things which do matter to our
> > developers and users, over things which dont and belive it or not
> > reading everything twice to fix spelling capitalization and all that
> > takes time, time i could spent fixing some issues
> 
> So readable documentation doesn't matter?  I find it odd that you
> insist on Doxygen comments everywhere, yet pay little or no attention
> to making these comments even remotely comprehensible, except possibly
> to yourself.

readable documentation does matter but a few spelling errors dont affect
readability IMHO
also correctly spelled != comprehensible documentation
i rather try to get the content comprehensible than getting the spelling
perfectly correct, certainly i do fail at the first part as well sometimes
but you cant blame me for honestly trying to get the content right ...


> 
> > also ive a suggestion, ill be more carefull with my spelling and you fix
> > a few issues on our bugtracker (and no i dont mean closing invalid ones but
> > real bugfixes which require a change of the C code)
> > i think that would be fair, it would require each of us to do something
> > we dont commonly do
> 
> Some us here have jobs to attend in the daytime, and thus have much
> less time to spend coding on FFmpeg.  Please keep that in mind before
> accusing people of being lazy.

it appears thouse dont lack time complaining about and fixing spelling
errors though
also just looking at the number of commits in mplayer-svn diego did, does not
give me the feeling that he has no time to work on the code


> 
> >> How about we start committing random broken code with the excuse that
> >> "Michael will fix it"?
> >
> > i would by reverting and asking root to remove your write access
> 
> Ah, but root doesn't take orders like that.

nah, root did last time i wanted somones account closed and root will again
as root knows ffmpeg will be moved to a differnt server if he misuses his
position. which after all he got because he volunteered not because anyone
gave him any authority
i never ask for someones access to be closed without sound reason, and it
was just needed once in the lifetime of ffmpeg ...

and frankly i do think you agree that someone who commits broken code
knowingly and intentionally (and i assume repeatetly) should not have
write access

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20071217/7f741763/attachment.pgp>