[Ffmpeg-cvslog] r7604 - trunk/libavformat/aiff.c

[Michael Niedermayer]

Hi

On Sun, Jan 21, 2007 at 02:56:32PM +0100, Alex Beregszaszi wrote:
> Hi,
> 
> > >> Modified: trunk/libavformat/aiff.c
> > >> ==============================================================================
> > >> --- trunk/libavformat/aiff.c	(original)
> > >> +++ trunk/libavformat/aiff.c	Sun Jan 21 13:47:46 2007
> > >> @@ -166,7 +166,6 @@
> > >>  
> > >>      /* First verify if format is ok */
> > >>      if (!enc->codec_tag) {
> > >> -        av_free(aiff);
> > >>          return -1;
> > >>      }
> > >
> > > And what about the useless {} ?
> > 
> > Useless but also harmless.

yes and there are many of these, and iam unsure if its worth to remove
them ...


> 
> Michael does code reduction / simplification / cosmetics in the last
> days :)

and actually this isnt a cosmetic but a bugfix because priv_data isnt
set to NULL so it should have been freed twice ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070121/94e1543c/attachment.pgp>