[Ffmpeg-cvslog] r7678 - trunk/libavcodec/bmp.c

[Michel Bardiaux]

michael wrote:
> Author: michael
> Date: Wed Jan 24 11:41:03 2007
> New Revision: 7678
> 
> Modified:
>    trunk/libavcodec/bmp.c
> 
> Log:
> enum
> 
> 
> Modified: trunk/libavcodec/bmp.c
> ==============================================================================
> --- trunk/libavcodec/bmp.c	(original)
> +++ trunk/libavcodec/bmp.c	Wed Jan 24 11:41:03 2007
> @@ -27,10 +27,12 @@
>      AVFrame picture;
>  } BMPContext;
>  
> -#define BMP_RGB       0
> -#define BMP_RLE8      1
> -#define BMP_RLE4      2
> -#define BMP_BITFIELDS 3
> +typedef enum {
> +    BMP_RGB=0,
> +    BMP_RLE8,
> +    BMP_RLE4,
> +    BMP_BITFIELDS,
> +} BiCompression;

The values are mandated by MS specs, so IMHO they should all be forced, 
or at least a comment to that effect.

Also, the same enum will be needed by the encoder, which will go in a 
different file, so should the enum go to some bmp.h or to avcodec.h or what?

Greetings,
-- 
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be

Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/