[Ffmpeg-cvslog] r7729 - in trunk: configure libavcodec/cabac.h

Måns Rullgård mru
Sat Jan 27 22:06:51 CET 2007


"Guillaume POIRIER" <poirierg at gmail.com> writes:

> Hi,
>
> On 1/27/07, mru <subversion at mplayerhq.hu> wrote:
>> Author: mru
>> Date: Sat Jan 27 15:10:57 2007
>> New Revision: 7729
>>
>> Modified:
>>    trunk/configure
>>    trunk/libavcodec/cabac.h
>>
>> Log:
>> rename CMOV_IS_FAST to HAVE_FAST_CMOV and simplify configure
>
> To me, knowing that CMOV is supported, and the fact that it's fast,
> are two different things.
>
> I can't think of an example right now to show when it could be
> profitable to use cmov even though it's slow, but if I understood
> correctly your change, P4 user will now use suboptimal CABAC code
> because they use an ASM code that depends on having a fast
> implementation of CMOV.

I made no functional change.  Whenever the cmov instruction is
available, HAVE_CMOV is defined.  If it also happens to be fast,
HAVE_FAST_CMOV is additionally defined.  I only changed the name of a
preprocessor symbol so the configure script could be simplified, and
to make naming more consistent.

If I made a mistake, and HAVE_FAST_CMOV is defined when it should not,
I'd be happy to rectify that, of course.

-- 
M?ns Rullg?rd
mru at inprovide.com




More information about the ffmpeg-cvslog mailing list