[FFmpeg-cvslog] r9547 - in trunk/libavcodec: cavs.h h264.c mpegvideo.h snow.c

[Roman Shaposhnick]

On Wed, 2007-07-11 at 21:38 +0100, M?ns Rullg?rd wrote:
> M?ns Rullg?rd <mans at mansr.com> writes:
> 
> > Michael Niedermayer <michaelni at gmx.at> writes:
> >
> >> Hi
> >>
> >> On Mon, Jul 09, 2007 at 02:38:46PM -0700, Roman Shaposhnik wrote:
> >>> Hi
> >>> 
> >>> On Mon, 2007-07-09 at 22:05 +0100, M?ns Rullg?rd wrote:
> >>> > >> So what do we do with this function?  Make it "extern inline"?  Move
> >>> > >> it to a header as "static inline"?
> >>> > >
> >>> > > hmm id say Move it to a header as "static inline"
> >>> > 
> >>> > Something like this then?
> >>> 
> >>>   Yes, but keeping ff_h263_chroma_roundtab[] separate from the
> >>> function itself might be more trouble than it is worth. Something
> >>> like:
> >>> 
> >>> static inline int ff_h263_round_chroma(int x){
> >>>     static const unsigned char ff_h263_chroma_roundtab[16]...
> >>
> >> iam not opposed to that ...
> >
> > The patch would look like this.
> 
> Which of these variants should I commit?

  I'd vote for the second one: 'static ... [16]'. But that's just one
vote.

Thanks,
Roman.