[Ffmpeg-cvslog] r8223 - trunk/libavformat/swf.c

[Benjamin Larsson]

Alex Beregszaszi skrev:
> Hi,
>
>   
>>>> @@ -333,9 +265,18 @@ static int swf_write_header(AVFormatCont
>>>>      audio_enc = NULL;
>>>>      for(i=0;i<s->nb_streams;i++) {
>>>>          enc = s->streams[i]->codec;
>>>> -        if (enc->codec_type == CODEC_TYPE_AUDIO)
>>>> -            audio_enc = enc;
>>>> -        else {
>>>> +        if (enc->codec_type == CODEC_TYPE_AUDIO) {
>>>> +            if (enc->codec_id == CODEC_ID_MP3) {
>>>> +                if (!enc->frame_size) {-
>>>> +                    av_log(s, AV_LOG_ERROR, "audio frame size not set\n");
>>>> +                    return -1;
>>>> +                }
>>>> +                audio_enc = enc;
>>>> +            } else {
>>>> +                av_log(enc, AV_LOG_ERROR, "SWF only supports MP3\n");
>>>> +                return -1;
>>>> +            }
>>>>         
>>> SWF supports PCM too
>>>       
>> Nellymoser, Adpcm too.
>>     
>
> What about adding support for PCM and ADPCM (one Benjamin's patch is
> committed)? Even in such a way that when using a codec, the appropriate
> minimum flash version is a requirement which implemented that codec
> first. Or this is not worth the hassle?
>
> --
> Alex Beregszaszi

Don't forget flashsv also, the encoder is there, or doesn't swf support 
flashsv encoded material ?

MvH
Benjamin Larsson