[Ffmpeg-cvslog] r8360 - trunk/libavutil/sha1.c

[Måns Rullgård]

Rich Felker <dalias at aerifal.cx> writes:

> On Mon, Mar 12, 2007 at 10:16:01PM +0000, M?ns Rullg?rd wrote:
>> michael <subversion at mplayerhq.hu> writes:
>> 
>> > Author: michael
>> > Date: Mon Mar 12 23:12:36 2007
>> > New Revision: 8360
>> >
>> > Modified:
>> >    trunk/libavutil/sha1.c
>> >
>> > Log:
>> > 10% smaller object file, 2% slower
>> 
>> Since when is object file size more important than speed?
>
> with anything crypto related, my first question as a user of lavu
> would be "wtf is that bloat doing in lavu?!" making it as small as

I've been asking the same question.

> possible mitigates the issue somewhat. also, michael's size
> optimizations overall seem to be simplifying the code too. and for
> crypto, simple==good.

That is true.  Now the log message only mentions a reduction in size
for the object file, no simplification.  I didn't look carefully at
the diffs.

-- 
M?ns Rullg?rd
mans at mansr.com