[Ffmpeg-cvslog] r8334 - trunk/libavformat/matroska.c

[Michael Niedermayer]

Hi

On Tue, Mar 13, 2007 at 03:35:27PM +0200, Uoti Urpala wrote:
> On Tue, 2007-03-13 at 13:53 +0100, Michael Niedermayer wrote:
> > the pts->dts code fails if EVERY of the following assumtations is true
> >     codec is h.264
> >     complex frame reordering is used (like b pyramid)
> >     pts are available
> >     dts are not available
> >     dts are equal to sorted pts
> 
> The code also seems to use pkt->duration, which cannot be known
> correctly based on pts without demuxing further. Does it always work
> right with simpler frame reordering but VFR? Also with the Matroska

ive already said that the code works, if you have found a case where
it fails (except h.264 stuff), then  please submit a bugreport


> sample I tested even the incorrect dts calculation logic was not
> triggered at all, but dts was always set equal to pts.

well id guess the matroska demuxer or parser forgot to set some things
correctly, maybe has_b_frames or the frame type, or maybe theres no
parser at all initalized ...
its not hard to put a few av_log() in compute_pkt_fields() to see what
goes wrong ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070313/58c211a8/attachment.pgp>