[Ffmpeg-cvslog] r8398 - trunk/libavcodec/h264.c

[Baptiste Coudurier]

Hi

Guillaume Poirier wrote:
> Hi,
> 
> bcoudurier wrote:
>> Author: bcoudurier
>> Date: Wed Mar 14 12:12:02 2007
>> New Revision: 8398
>>
>> Modified:
>>    trunk/libavcodec/h264.c
>>
>> Log:
>> h264 complete frames parsing support
> 
> 
> Could you explain what does this change provides?

If parser flags is set to PARSE_COMPLETE_FRAMES (st->need_parsing == 2
do that), it won't try to reconstruct frames and thereforce avoid
copy/combine.

> What was the shortcoming of previous implementation that required that
> patch?

matroska demuxer will set need_parsing to 2, see thread :
"[Ffmpeg-cvslog] r8334 - trunk/libavformat/matroska.c"

funny thing is that avi demuxer set need_parsing to 2, so I guess this
speed up h264 in avi demuxing.

> I'm just curious, I don't mean to question the necessity of that
> change, just wanna understand a bit of it.
> 

you're welcome.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312