[Ffmpeg-cvslog] r8403 - trunk/libavcodec/mpeg12.c

[Michael Niedermayer]

Hi

On Wed, Mar 14, 2007 at 02:35:47PM +0100, Baptiste Coudurier wrote:
> Hi
> 
> michael wrote:
> > Author: michael
> > Date: Wed Mar 14 14:20:29 2007
> > New Revision: 8403
> > 
> > Modified:
> >    trunk/libavcodec/mpeg12.c
> > 
> > Log:
> > 10l to whoever wrote this
> > 
> > 
> > Modified: trunk/libavcodec/mpeg12.c
> > ==============================================================================
> > --- trunk/libavcodec/mpeg12.c	(original)
> > +++ trunk/libavcodec/mpeg12.c	Wed Mar 14 14:20:29 2007
> > @@ -828,8 +828,7 @@ void ff_mpeg1_encode_init(MpegEncContext
> >  
> >          done=1;
> >          init_rl(&rl_mpeg1, static_rl_table_store[0]);
> > -        if(s->intra_vlc_format)
> > -            init_rl(&rl_mpeg2, static_rl_table_store[1]);
> > +        init_rl(&rl_mpeg2, static_rl_table_store[1]);
> >  
> >          for(i=0; i<64; i++)
> >          {
> 
> It's me, may I ask why is it stupid ? 

of course you may :)


> rl_mpeg2 seems only used when
> intra_vlc_format specific to mpeg2 is activated.

static int done=0;

if(!done){
    done=1
    if(the current context needs X)
        init X
}

well first encoder doesnt need X, so its not initalized but done is set to 1
now second mpeg encoder needs X but done is 1 so it wont be inited ...
of course its debateable if the static int done think should be there at all
...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070314/5e566893/attachment.pgp>