[FFmpeg-cvslog] r10889 - trunk/libavcodec/allcodecs.c

[Aurelien Jacobs]

Michael Niedermayer wrote:

> Hi
> 
> On Wed, Oct 31, 2007 at 11:55:46PM +0100, Aurelien Jacobs wrote:
> > michael wrote:
> > 
> > > Author: michael
> > > Date: Wed Oct 31 23:39:10 2007
> > > New Revision: 10889
> > > 
> > > Log:
> > > prefer our native vorbis decoder over libvorbis
> > 
> > It also affect encoder...
> > And libvorbis encoder is certainly preferred over the native one.
> 
> hum why?
> 
> dont you want someone to fix it so its quality is better than libvorbis?

Sure I do. But I'm not sure this change will help much in this respect.

> > > Modified:
> > >    trunk/libavcodec/allcodecs.c
> > > 
> > > Modified: trunk/libavcodec/allcodecs.c
> > > ==============================================================================
> > > --- trunk/libavcodec/allcodecs.c	(original)
> > > +++ trunk/libavcodec/allcodecs.c	Wed Oct 31 23:39:10 2007
> > > @@ -191,7 +191,6 @@ void avcodec_register_all(void)
> > >      REGISTER_ENCDEC  (LIBGSM_MS, libgsm_ms);
> > >      REGISTER_ENCODER (LIBMP3LAME, libmp3lame);
> > >      REGISTER_ENCODER (LIBTHEORA, libtheora);
> > > -    REGISTER_ENCDEC  (LIBVORBIS, libvorbis);
> > >      REGISTER_DECODER (MACE3, mace3);
> > >      REGISTER_DECODER (MACE6, mace6);
> > >      REGISTER_ENCDEC  (MP2, mp2);
> > > @@ -215,6 +214,7 @@ void avcodec_register_all(void)
> > >      REGISTER_ENCDEC  (WMAV1, wmav1);
> > >      REGISTER_ENCDEC  (WMAV2, wmav2);
> > >      REGISTER_DECODER (WS_SND1, ws_snd1);
> > > +    REGISTER_ENCDEC  (LIBVORBIS, libvorbis);
> > 
> > I don't like this change very much...
> 
> yes yes, i expected flames
> thanks for proofing that i guessed right ;)

:-)
Note that I didn't even talk about wrong sorting ;-)
BTW: I bet that someone will sort it again at some point,
just for the shake of sorting.

> > Default ./configure will enable native vorbis and disable libvorbis.
> > If user intentionally enable libvorbis, that's probably because he
> > want to use it. Thus it should probably be preferred over vorbis.
> 
> i use --enable-libvorbis but dont want it used by default, what should i
> do?

I use --enable-libvorbis and want it used by default, what should i do?
The fact is that this codec list is not a way to specify user preferred
codec order...

> also binaries from distros will likely have it enabled by default and that
> might not match what the user wants to use by default
> 
> 
> > Oh, and the best way to fix this anyway is to drop support for
> > libvorbis decoding ;-)
> 
> that would make debuging the decoder harder, so feel free to drop it
> after you overtook maintainership of our vorbis decoder :)

No, thanks...
I thought native decoder was already bullet proof, and that it was
almost agreed that we should remove libvorbis decoder. It seems I
was wrong.

Aurel