[FFmpeg-cvslog] r14692 - in trunk: libavcodec/pcm.c tests/regression.sh

[pross at xvid.org]

On Mon, Aug 11, 2008 at 09:00:11PM -0700, Mike Melanson wrote:
> pross at xvid.org wrote:
> > On Mon, Aug 11, 2008 at 06:58:23AM -0700, Mike Melanson wrote:
> >> pross wrote:
> >>> Author: pross
> >>> Date: Mon Aug 11 11:52:17 2008
> >>> New Revision: 14692
> >>>
> >>> Log:
> >>> Apply PCM ENCODE/DECODE() macros to the S/U,8/24/32,LE/BE PCM codecs.
> >>>
> >>>
> >>> Modified:
> >>>    trunk/libavcodec/pcm.c
> >>>    trunk/tests/regression.sh
> >> This altered the results of 5 different FATE test specs. Is that expected?
> > 
> > If you are using 'crc' or 'frame' crc to validate the output, then Yes, the
> > calculated CRC will be different for PCM U,U,8/24/32,LE,BE PCM codecs. The
> > reason: libavcodec now stores audio samples in the optimal immediate format
> > (8-bit,16-bit,32-bit,float), whereas previously it just used shorts.
> > 
> > The crc and framecrc work on the intermediate samples, hence the FATE results.
> > If your test cases were 'md5sum a transcoded wave file' then the md5sums
> > would be identical.
> 
> This explanation does not match what I am seeing. Not all of the 
> unsigned PCM tests broke. E.g., qt-rawpcm-8bit-mono-unsigned broke:
> 
>    http://fate.multimedia.cx/index.php?test_spec=64
> 
> But for some reason, qt-rawpcm-8bit-stereo-unsigned is still the same:
> 
>    http://fate.multimedia.cx/index.php?test_spec=74
> 
> These are both of the 'md5sum a transcoded wave file' variety.

Okay. This file, an presumably others in the suite, has odd-number of U8 samples
per packet. This would be fine, execept that the number of decoded U8 samples is
calculated using some lazy logic (number of short ints / 2). 

See patch.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pcmu8-fix-counter.diff
Type: text/x-diff
Size: 410 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080812/06944b5b/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080812/06944b5b/attachment.pgp>