[FFmpeg-cvslog] r14209 - in trunk/libavformat: allformats.c gifdec.c

[Michael Niedermayer]

On Sun, Jul 13, 2008 at 10:12:04PM -0700, Baptiste Coudurier wrote:
> Hi,
> 
> michael wrote:
> > Author: michael
> > Date: Sun Jul 13 20:47:24 2008
> > New Revision: 14209
> > 
> > Log:
> > Remove gif demuxer, the code contains a gif decoder and lzw decoder neither
> > belongs in a demuxer, furthermore the code might be exploitable.
> > Fixes issue530
> 
> Yes, and yes. However current decoder cannot handle animated gifs, that
> is why this demuxer is still present. Handling animated gifs through
> image2 is not obvious because parsing these gifs and extracting each
> picture with a parser would be quite equivalent to decode them.

True, but when you skip the spliting and just pass the whole animated gif
in a single AVPacket to lavc, then theres no such problem ...
Its not nice design but its alot better than libavformat/gifdec.c was


> 
> So here we lost a feature which worked, and I don't like it much, even
> if I understand. Can you please point at exploitable problems if you
> remember them right now ? I'll look at it.

issue530 and reimar already fixed it IIRC. But I really would prefer
if this demuxer would stay in the trashcan its a ugly and messy duplication
of the code in lavc.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080714/c7d6317d/attachment.pgp>